| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-decimal integer literals |
| Date: | 2021-12-01 15:40:19 |
| Message-ID: | 3a3cc5e5-3d70-cdb9-f7a3-139d7d8742b9@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25.11.21 16:46, Zhihong Yu wrote:
> For patch 3,
>
> +int64
> +pg_strtoint64(const char *s)
>
> How about naming the above function pg_scanint64()?
> pg_strtoint64xx() can be named pg_strtoint64() - this would align with
> existing function:
>
> pg_strtouint64(const char *str, char **endptr, int base)
That would be one way. But the existing pg_strtointNN() functions are
pretty widely used, so I would tend toward finding another name for the
less used pg_strtouint64(), maybe pg_strtouint64x() ("extended").
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-12-01 15:44:13 | Re: Update stale code comment in CheckpointerMain() |
| Previous Message | Robert Haas | 2021-12-01 15:38:27 | Re: RecoveryInProgress() has critical side effects |