From: | Josh Wilmes <jwilmes(at)cisco(dot)com> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org, Nick Johnson <njohnson(at)cisco(dot)com> |
Subject: | Re: ISM shared memory on solaris |
Date: | 2003-10-27 18:36:34 |
Message-ID: | 3F9D65B2.2000400@cisco.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-patches |
Seems like the BEST case would be to have a configure test verify that
it works and define something if it does, but i don't know what such a
test would look like.
--Josh
Bruce Momjian wrote:
> Tom Lane wrote:
>
>>Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>
>>
>>>! #if defined(sun) && defined(__sparc__)
>>> /* use intimate shared memory on SPARC Solaris */
>>> memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
>>> #else
>>
>>I think this is going in the wrong direction. Why isn't the code just
>>
>>#if defined(SHM_SHARE_MMU)
>> /* use intimate shared memory on Solaris */
>> memAddress = shmat(shmid, 0, SHM_SHARE_MMU);
>>#else
>>
>>If the symbol is available I think we probably want to use it. It is an
>>O/S issue, not a hardware issue, and so the test on __sparc__ seems
>>quite wrongheaded ...
>
>
> What I was hoping to do with the define test was to throw an error if we
> don't find intimate shared memory on Solaris, but the define doesn't
> work fir i386/Solaris so we are probably better going with the define as
> you suggest --- I just hope we don't fail to include a file and somehow
> miss it on some version of Solaris.
>
> Change applied.
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-10-27 20:08:55 | Re: Transaction bug |
Previous Message | Bruce Momjian | 2003-10-27 18:30:14 | Re: ISM shared memory on solaris |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2003-10-27 23:33:16 | "make check" improvement for cygwin |
Previous Message | Bruce Momjian | 2003-10-27 18:30:14 | Re: ISM shared memory on solaris |