Re: SSL detection bug is back under debian...

From: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
To: "Adam H(dot) Pendleton" <fmonkey(at)fmonkey(dot)net>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: SSL detection bug is back under debian...
Date: 2003-10-16 13:47:43
Message-ID: 3F8EA17F.5080402@club-internet.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Adam H. Pendleton wrote:

> Raphaël Enrici wrote:
>
>> Dear Adam,
>> Jean-Michel reported to me this morning that the SSL menu was empty
>> under debian builds.
>> I had a quick look to the build process and it seems that we still
>> have "-I -DSSL" while in the make all-recursive.
>
> The attached patch should solve this pesky SSL bug once and for all.
> Let me know if you have any problems with it.

Adam,
thank you for this fast released patch. I haven't tried it for now but
AFAICS it does not seem to handle the fact that WX_HOME is undef after
configure on my system. I think that the real problem comes from this.
In fact, SSL was correctly detected but was ignored due to the fact that
WX_HOME was empty which gave the '-I -DSSL'. Do you have any idea
concerning this ? I'll try your patch tonight or tomorrow.

regards,
Raphaël

> ahp
>
>------------------------------------------------------------------------
>
>--- pgadmin3/acinclude.m4 2003-10-09 16:40:21.000000000 -0400
>+++ pgadmin3.new/acinclude.m4 2003-10-16 08:23:32.000000000 -0400
>@@ -93,8 +93,6 @@
> fi
> ])
>
>-CPPFLAGS="$CPPFLAGS -DSSL"
>-
> #
> # Check for libpq libraries and headers
> #
>@@ -118,6 +116,7 @@
> AC_LANG_SAVE
> AC_LANG_C
> AC_CHECK_LIB(pq, PQexec, [pgsql_cv_libpq=yes], [pgsql_cv_libpq=no])
>+ AC_CHECK_LIB(pq, SSL_connect, [pgsql_ssl_libpq=yes], [pgsql_ssl_libpq=np])
> AC_CHECK_HEADER(libpq-fe.h, [pgsql_cv_libpqfe_h=yes], [pgsql_cv_libpqfe_h=no])
> AC_LANG_RESTORE
> if test "$pgsql_cv_libpq" = "yes" -a "$pgsql_cv_libpqfe_h" = "yes"
>@@ -131,6 +130,11 @@
> CPPFLAGS="$PGSQL_OLD_CPPFLAGS"
> AC_MSG_ERROR([you must specify a valid pgsql installation with --with-pgsql=DIR])
> fi
>+
>+ if test "$pgsql_ssl_libpq" = "yes"
>+ then
>+ CPPFLAGS="$CPPFLAGS -DSSL"
>+ fi
> fi
> ])
>
>
>
>
>------------------------------------------------------------------------
>
>
>---------------------------(end of broadcast)---------------------------
>TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Andreas Pflug 2003-10-16 13:48:37 Re: Font debugging code
Previous Message Dave Page 2003-10-16 13:19:30 Re: Font debugging code