Re: pg_get_ruledef and extra line breaks

Christopher Kings-Lynne wrote:

>Hi,
>
>I notice that the pretty printing version of pg_get_ruledef inserts extra
>newlines whereas all the others pretty functions (except view defs) do
>not. In fact, Andreas argued against a version of pg_get_triggerdef()
>that added extra newlines.
>
No, I did not *in general*, but for now because there's no node
traversing and a pretty formatted query can be easily constructed by
yourself as for all other non-pg_get_xxx supported objects.

>
> CREATE RULE asdfx AS
> ON INSERT TO test
> WHERE 1 = 1 OR 1 = 2 OR 1 = 3 OR 1 = 5 DO INSTEAD NOTHING;
> CREATE RULE asdf AS
> ON INSERT TO test
> WHERE 1 = 1 OR 1 = 2 OR 1 = 3 OR 1 = 5 DO INSTEAD NOTHING;
>(8 rows)
>
>
>Are those newlines really necessary? They seem a bit out of place?
>
Matter of taste. Things look different if action is not NOTHING, but
something more.

Regards,
Andreas