From: | Manfred Spraul <manfred(at)colorfullife(dot)com> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCHES] Reorganization of spinlock defines |
Date: | 2003-09-12 21:14:23 |
Message-ID: | 3F62372F.7080901@colorfullife.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
>Tom Lane wrote:
>
>
>>Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>
>>
>>>He is uncomfortable with the port/*.h changes at this point, so it seems
>>>I am going to have to add Itanium/Opteron tests to most of those files.
>>>
>>>
>>Why don't you try to put together a proposed patch of that kind, and
>>then we can look to see how big and ugly it is compared to the other?
>>If the alternative is shown to be really messy, that would sway my
>>opinion, maybe Marc's too.
>>
>>
>
>OK, here is an Opteron/Itanium patch that might work. I say "might"
>because I don't have a lot of confidence in the current spinlock
>detection code. There is an uncoupling between the definition of
>HAS_TEST_AND_SET, the data type used by slock_t, and the assembler code.
>
>
Is the Itanium tas implementation correct? I think it should be
xchg4.aqv instead of just xchg4 - as far as I know a normal atomic
exchange is is not a memory barrier on Itanium. At least the Linux
kernel version contains "cmpxchg4.aqv".
--
Manfred
From | Date | Subject | |
---|---|---|---|
Next Message | Carlos Guzman Alvarez | 2003-09-12 21:28:09 | [ANN] PGSqlClient 1.0 Beta 1 released |
Previous Message | Tilo Schwarz | 2003-09-12 20:15:58 | Re: plpython |
From | Date | Subject | |
---|---|---|---|
Next Message | Manfred Spraul | 2003-09-12 21:30:51 | Re: [PATCHES] Reorganization of spinlock defines |
Previous Message | Peter Eisentraut | 2003-09-12 19:20:48 | Re: Reorganization of spinlock defines |