From: | Jan Wieck <JanWieck(at)Yahoo(dot)com> |
---|---|
To: | Kurt Roeckx <Q(at)ping(dot)be> |
Cc: | Jan Wieck <JanWieck(at)Yahoo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Matthew T(dot) O'Connor" <matthew(at)zeut(dot)net>, akavan(at)cox(dot)net, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Stats Collector Error 7.4beta1 and 7.4beta2 |
Date: | 2003-09-04 21:01:54 |
Message-ID: | 3F57A842.6050904@Yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Kurt Roeckx wrote:
> It could be useful to have a warning at the following line:
>
> if (memcmp(&fromaddr, &pgStatAddr, fromlen))
> continue;
>
> That way you can rule out that that is a problem.
>
> Anyway, I still didn't see the error message he got in the first
> place. Maybe we're looking at the wrong thing?
I think it's more this piece of code in postmaster/pgstat.c
/*
* The source address of the packet must be our own socket.
* This ensures that only real hackers or our own backends
* tell us something. (This should be redundant with a
* kernel-level check due to having used connect(), but let's
* do it anyway.)
*/
if (memcmp(&fromaddr, &pgStatAddr, fromlen))
continue;
Jan
--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #
From | Date | Subject | |
---|---|---|---|
Next Message | Kurt Roeckx | 2003-09-04 21:14:23 | Re: Stats Collector Error 7.4beta1 and 7.4beta2 |
Previous Message | Merlin Moncure | 2003-09-04 20:51:32 | Re: Win32 native port |