Re: suspicous looking code in copy.c

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: dave(at)fastcrypt(dot)com
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: suspicous looking code in copy.c
Date: 2003-08-28 12:19:07
Message-ID: 3F4DF33B.6090503@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dave Cramer wrote:

>This just doesn't look right.
>
>line 364
> case COPY_NEW_FE:
>
> while (datasize > 0 && !fe_eof)
> ....
>
>line 408 datasize =- avail;
>
>
>shouldn't it be datasize -= avail ?
>
>
AFAIR this is a really outdated K&R style of -= . Compilers *should*
recognize this (and will throw an ambiguity error if there's no space
after =- ), but it's better to use the 'newer' style.

Regards,
Andreas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ohp 2003-08-28 12:41:58 Index creation takes for ever
Previous Message Christopher Browne 2003-08-28 12:11:44 Re: [HACKERS] 2-phase commit