Re: concat_ws

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hans Spaans <pgsql-admin(at)lists(dot)hansspaans(dot)nl>, pgsql-admin(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: concat_ws
Date: 2003-08-04 01:37:52
Message-ID: 3F2DB8F0.9040605@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers

Tom Lane wrote:
> I added code to inline_function to stop inlining if a parameter
> expression to be substituted multiple times has cost greater than
> 10*cpu_operator_cost (which roughly means that it contains more than
> 10 operators or functions). This seems to cut off the problem nicely,
> at least for this example. The factor of 10 is a bit of a magic number
> but it seems reasonable.
>

That did it (on fresh copy of cvs):

regression=# explain analyze select
concat_ws('~','01','02','03','04','05','06','07','08','09','10','11','12','13','14','15','16','17','18','19','20','21','22','23','24','25','26','27','28','29','30','31');
QUERY PLAN
----------------------------------------------------------------------------------
Result (cost=0.00..0.11 rows=1 width=0) (actual time=2.37..2.37
rows=1 loops=1)
Total runtime: 2.66 msec
(2 rows)

Thanks Tom!

Joe

In response to

Browse pgsql-admin by date

  From Date Subject
Next Message Dennis Björklund 2003-08-04 05:44:37 Re: concat_ws
Previous Message Tom Lane 2003-08-03 23:53:57 Re: concat_ws

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-08-04 01:55:34 Re: new compile warning
Previous Message Joe Conway 2003-08-04 01:34:55 new compile warning