Re: Fix for getXXX (numbers)

From: Barry Lind <blind(at)xythos(dot)com>
To: Kim Ho <kho(at)redhat(dot)com>
Cc: pgsql-jdbc-list <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Fix for getXXX (numbers)
Date: 2003-07-24 15:52:53
Message-ID: 3F2000D5.5070006@xythos.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Kim,

Can you explain the problem this patch is trying to solve? On the face
of it I don't see what is wrong with the existing code.

thanks,
--Barry

Kim Ho wrote:
> This patch was written by Yoshihiro Yasuoka of Fujitsu.
>
> Thanks,
>
> Kim
>
> On Tue, 2003-07-22 at 15:06, Kim Ho wrote:
>
>>Would help if I attach it.
>>
>>On Tue, 2003-07-22 at 14:23, Kim Ho wrote:
>>
>>>Fixes the way the jdbc driver handles numbers when it gets them from
>>>backend. Courtesy of Fujitsu.
>>>
>>>Cheers,
>>>
>>>Kim
>>>
>>>
>>>---------------------------(end of broadcast)---------------------------
>>>TIP 5: Have you checked our extensive FAQ?
>>>
>>> http://www.postgresql.org/docs/faqs/FAQ.html
>>
>>----
>>
>
>
>>Index: org/postgresql/jdbc1/AbstractJdbc1ResultSet.java
>>===================================================================
>>RCS file: /projects/cvsroot/pgsql-server/src/interfaces/jdbc/org/postgresql/jdbc1/AbstractJdbc1ResultSet.java,v
>>retrieving revision 1.13
>>diff -c -p -r1.13 AbstractJdbc1ResultSet.java
>>*** org/postgresql/jdbc1/AbstractJdbc1ResultSet.java 30 Jun 2003 21:10:55 -0000 1.13
>>--- org/postgresql/jdbc1/AbstractJdbc1ResultSet.java 22 Jul 2003 18:20:57 -0000
>>*************** public abstract class AbstractJdbc1Resul
>>*** 805,811 ****
>> try
>> {
>> s = s.trim();
>>! return Integer.parseInt(s);
>> }
>> catch (NumberFormatException e)
>> {
>>--- 805,811 ----
>> try
>> {
>> s = s.trim();
>>! return Float.valueOf(s).intValue();
>> }
>> catch (NumberFormatException e)
>> {
>>*************** public abstract class AbstractJdbc1Resul
>>*** 822,828 ****
>> try
>> {
>> s = s.trim();
>>! return Long.parseLong(s);
>> }
>> catch (NumberFormatException e)
>> {
>>--- 822,828 ----
>> try
>> {
>> s = s.trim();
>>! return Double.valueOf(s).longValue();
>> }
>> catch (NumberFormatException e)
>> {
>>----
>>
>
>
>>---------------------------(end of broadcast)---------------------------
>>TIP 7: don't forget to increase your free space map settings
>
>
>
>

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Felipe Schnack 2003-07-24 17:03:03 development driver
Previous Message Kim Ho 2003-07-24 13:50:26 Re: Fix for getXXX (numbers)