Re: array support patch phase 1 patch

From: Joe Conway <mail(at)joeconway(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: array support patch phase 1 patch
Date: 2003-06-02 17:30:03
Message-ID: 3EDB899B.2000206@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Joe Conway wrote:
> Tom Lane wrote:
>> I'm not sure though that any of these cases really are of concern. Do
>> we care in any of them whether failure to find the operator is postponed
>> till runtime? ANALYZE needs to know because it has a fallback path if
>> there's no "<" operator, but ORDER BY does not.
>
> I was thinking the same thing and hoping you'd say that. I'll send in an
> updated patch later this morning once I've done a bit more testing.

Here is an updated array-combo patch. Only change is that this one moves
the check for missing array element type equality and ordering operators
into equality_oper() and ordering_oper(), per recent discussion.

The patch applys cleanly on cvs as of this morning, compiles without any
(new) warnings, initdb's fine, and passes all 90 regression tests.

Please apply.

Thanks,

Joe

Attachment Content-Type Size
array-combo.04.patch text/plain 155.7 KB

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Kris Jurka 2003-06-02 17:34:28 Re: array support patch phase 1 patch
Previous Message Josh Berkus 2003-06-02 17:15:28 Re: Proposal for Re-ordering CONF (was: Re: GUC and postgresql.conf docs)