Re: compile error on cvs tip

Tom Lane wrote:
>>I also get this new warning:
>>be-secure.c: In function `open_server_SSL':
>>be-secure.c:712: warning: assignment from incompatible pointer type
>
> I can't see any reason for that --- the relevant code hasn't been
> changed lately (at least not by me). Can you look to see what the
> discrepancy in types is?

The definition in (at least my copy of) ssl.h for info_callback is:
void (*info_callback)(const SSL *ssl,int type,int val);
^^^^^

The following seems to take care of it. I just recently updated to Red
Hat 9, so this may be showing up now due to a newer gcc or openssl.

Joe

Index: src/backend/libpq/be-secure.c
===================================================================
RCS file: /opt/src/cvs/pgsql-server/src/backend/libpq/be-secure.c,v
retrieving revision 1.30
diff -c -r1.30 be-secure.c
*** src/backend/libpq/be-secure.c 19 Apr 2003 00:02:29 -0000 1.30
--- src/backend/libpq/be-secure.c 25 Apr 2003 04:23:53 -0000
***************
*** 115,121 ****
static DH *load_dh_buffer(const char *, size_t);
static DH *tmp_dh_cb(SSL *s, int is_export, int keylength);
static int verify_cb(int, X509_STORE_CTX *);
! static void info_cb(SSL *ssl, int type, int args);
static int initialize_SSL(void);
static void destroy_SSL(void);
static int open_server_SSL(Port *);
--- 115,121 ----
static DH *load_dh_buffer(const char *, size_t);
static DH *tmp_dh_cb(SSL *s, int is_export, int keylength);
static int verify_cb(int, X509_STORE_CTX *);
! static void info_cb(const SSL *ssl, int type, int args);
static int initialize_SSL(void);
static void destroy_SSL(void);
static int open_server_SSL(Port *);
***************
*** 547,553 ****
* into the PostgreSQL log.
*/
static void
! info_cb(SSL *ssl, int type, int args)
{
switch (type)
{
--- 547,553 ----
* into the PostgreSQL log.
*/
static void
! info_cb(const SSL *ssl, int type, int args)
{
switch (type)
{