| From: | Alexey Klyukin <alexk(at)commandprompt(dot)com> |
|---|---|
| To: | Joshua Tolley <eggyknap(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: plperl and inline functions -- first draft |
| Date: | 2009-11-20 14:34:45 |
| Message-ID: | 3E4C20CD-AEE7-4C33-BC07-2F036E0C8ED9@commandprompt.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Nov 20, 2009, at 2:04 AM, Joshua Tolley wrote:
> On Wed, Nov 18, 2009 at 12:38:00PM +0200, Alexey Klyukin wrote:
>> Yes, current_call_data can't be allocate in the SPI memory context, since it's used to extract the result after SPI_finish is called, although it doesn't lead to problems here since no result is returned. Anyway, I'd move SPI_connect after the current_call_data initialization.
>>
>> I also noticed that no error context is set in the inline handler, not sure whether it really useful except for the sake of consistency, but in case it is - here is the patch:
>
> Makes sense on both counts. Thanks for the help. How does the attached look?
These two problems seem to be fixed now, thank you.
--
Alexey Klyukin http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Klyukin | 2009-11-20 14:40:14 | Re: plperl and inline functions -- first draft |
| Previous Message | Andrew Dunstan | 2009-11-20 14:25:32 | Re: enable-thread-safety defaults? |