Re: UUID v7

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Sergey Prokhorenko <sergeyprokhorenko(at)yahoo(dot)com(dot)au>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Mat Arye <mat(at)timescaledb(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, Stepan Neretin <sncfmgg(at)gmail(dot)com>
Subject: Re: UUID v7
Date: 2024-11-16 19:06:03
Message-ID: 3E42A616-37AE-4EF3-B4C8-96977EC85A9B@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On 15 Nov 2024, at 06:44, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> IIUC v29 patch implements UUIDv7 generation in this way. So I've
> reviewed v29 patch and here are some review comments:

I believe I've addressed all your comments in v31 with one exception:
get_clock_timestamp_ns() does not return ascending values, because it resides in too generic place. So there's get_real_time_ns_ascending() in uuid.c.

Should we make a note about get_clock_timestamp_ns() returning only microseconds somewhere?

Also, maybe let's steal 2 random bits (from version or variant) and mix it into increased_clock_precision on MacOS?

Thank you!

Best regards, Andrey Borodin.

Attachment Content-Type Size
v31-0001-Implement-UUID-v7.patch application/octet-stream 18.8 KB

In response to

  • Re: UUID v7 at 2024-11-15 01:44:19 from Masahiko Sawada

Responses

  • Re: UUID v7 at 2024-11-17 18:39:18 from Andrey M. Borodin

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-11-16 20:22:57 Re: CI and test improvements
Previous Message Tom Lane 2024-11-16 18:00:44 Re: Potential ABI breakage in upcoming minor releases