Re: [HACKERS] PATCH: multivariate histograms and MCV lists

From: Mark Dilger <hornschnorter(at)gmail(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Date: 2017-11-25 20:25:49
Message-ID: 3E0AB13D-1AD8-40F0-8BBF-A2898B1C808F@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On Nov 18, 2017, at 12:28 PM, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>
> Hi,
>
> Attached is an updated version of the patch, adopting the psql describe
> changes introduced by 471d55859c11b.
>
> regards
>
> --
> Tomas Vondra http://www.2ndQuadrant.com
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
> <0001-multivariate-MCV-lists.patch.gz><0002-multivariate-histograms.patch.gz>

In src/backend/statistics/mcv.c, you have a few typos:

+ * there bo be a lot of duplicate values. But perhaps that's not true and we

+ /* Now it's safe to access the dimention info. */

+ * Nowe we know the total expected MCV size, including all the pieces

+ /* pased by reference, but fixed length (name, tid, ...) */

In src/include/statistics/statistics.h, there is some extraneous whitespace that needs
removing.

mark

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2017-11-25 21:01:06 Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Previous Message Mark Dilger 2017-11-25 20:23:17 Re: [HACKERS] PATCH: multivariate histograms and MCV lists