Re: Float output formatting options

From: "Pedro M(dot) Ferreira" <pfrazao(at)ualg(dot)pt>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Float output formatting options
Date: 2002-11-04 18:28:28
Message-ID: 3DC6BC4C.2020600@ualg.pt
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
>
> Yeah. In fact I'd be inclined to remove the static variable and make
> the code match float8out exactly (do "DBL_DIG + extra_float_digits").

P_MAXDIG is only used in the lines below:

#define P_MAXDIG DBL_DIG
#define P_MAXLEN (2*(P_MAXDIG+7)+1)
static int digits8 = P_MAXDIG;

Is it ok to remove #define P_MAXDIG DBL_DIG,
change P_MAXLEN to 2*(DBL_DIG+7)+1) and
remove the line 'static int digits8 = P_MAXDIG;' ?

Would then change the two geo output functions and replace digits8 by
DBL_DIG in the #ifdef GEODEBUG / #enfif output stuff.

>>There a bunch of other places where output is produced. They are all
>>within #ifdef GEODEBUG / #enfif blocks. Should these be corrected the
>>same way ?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-11-04 18:36:27 Re: v7.3Beta4 Tag'd and Packaged ...
Previous Message Tom Lane 2002-11-04 18:14:48 Re: Float output formatting options