Re: droped out precise time calculations in src/interfaces/libpq/fe-connect.c

From: Joe Conway <mail(at)joeconway(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Denis A Ustimenko <denis(at)oldham(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: droped out precise time calculations in src/interfaces/libpq/fe-connect.c
Date: 2002-10-16 06:00:02
Message-ID: 3DAD0062.2040400@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Well, the fact you see a change of 0.0002 is significant. Let me add
> that in the old code there was only one time() call _in_ the loop, while
> now, there are two, so I can easily see there are several additional
> time() calls. Did you put your calls in the while loop?
>

Not the first time, but I moved it around (into the loop in connectDBComplete,
and just before select() in pqWaitTimed) and it didn't seem to make any
difference. Then I removed it entirely again, and still got 0.0089 seconds
average. So, at the least, 0.0002 worth of variation seems to be related to
the development machine itself.

Joe

p.s. The good news is that with tens of thousands more tests at 1 second
timeout, still zero connection failures!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Anuradha Ratnaweera 2002-10-16 06:13:15 Re: Postgresql and multithreading
Previous Message Bruce Momjian 2002-10-16 05:51:28 Re: Postgresql and multithreading