Re: [PATCHES] Escape handling in strings

From: Michael Glaesemann <grzm(at)myrealbox(dot)com>
To:
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Escape handling in strings
Date: 2005-06-17 05:09:50
Message-ID: 3DA88477-07C4-4BBF-B59E-E698613A1AAC@myrealbox.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


On Jun 17, 2005, at 12:33 PM, Tom Lane wrote:

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>
>> OK, the current patch warns about two things, \' with one message,
>> and
>> any backslash in a non-E string with a different message.
>>
>
> Those are two very different things. \' is easy to get around and
> there's no very good reason not to send '' instead. But avoiding all
> use of \anything is impossible (think \\) so a non-suppressable
> warning
> for that would be quite unacceptable IMHO. I think it's much too
> early
> to be throwing a warning for \anything anyway. 8.2 or so, OK, but not
> in this cycle.

I think giving users a longer period of time to make the necessary
changes to their apps is very useful. If (as I understand) we're
giving them the opportunity to use E'' strings if they want to
continue to use \ for escaping, they can get rid of the warnings now,
by using E'' strings or using '' to escape. Getting people to
migrate something such as this is difficult and will take them quite
a while, I imagine. Giving them a longer time to change their
behavior as well as reinforcing it with a warning is helpful. They
can also easily check if they've got places they've missed in
changing their code, because the warnings will be prominent in their
logs.

Michael Glaesemann
grzm myrealbox com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2005-06-17 07:00:59 Re: Autovacuum in the backend
Previous Message Thomas F. O'Connell 2005-06-17 04:55:34 Re: Autovacuum in the backend

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Stark 2005-06-17 07:34:46 Re: [PATCHES] Escape handling in strings
Previous Message Bruce Momjian 2005-06-17 04:22:41 Re: [PATCHES] Escape handling in strings