Re: make_greater_string busted

From: Joe Conway <mail(at)joeconway(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: make_greater_string busted
Date: 2002-09-18 23:53:50
Message-ID: 3D89120E.2010009@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> I see in your recent bytea-LIKE patch
>
> if (datatype != BYTEAOID && pg_database_encoding_max_length() > 1)
> len = pg_mbcliplen((const unsigned char *) workstr, len, len - 1);
> else
> len -= -1;
>
> Surely there's one too many minus signs in that last?

Bug by Joe; review by Tom; patch attached; please apply.

Almost sounds like a short poem ;-)

Joe

Attachment Content-Type Size
make_greater_string-fix.1.patch text/plain 872 bytes

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-09-18 23:56:26 Re: make_greater_string busted
Previous Message Neil Conway 2002-09-18 23:19:55 to_char() code cleanup