Re: contrib/cube & contrib/seg regression fixes

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/cube & contrib/seg regression fixes
Date: 2002-09-15 04:53:51
Message-ID: 3D84125F.80408@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> AFAICT, bison 1.28 (what I have here) cannot emit any message mentioning
> "unexpected"; the word just plain does not appear in bison.simple.
> "unexpected $undefined." does not exactly seem like a major advance in
> error-message technology anyway :-(.
>
> I suggest we sit tight and hope that the bison guys get their act
> together, soon.

I figured as much. Thanks for looking at it.

FWIW, both seg and cube have "#define YYERROR_VERBOSE", which seems to add the
expected/unexpected text. It might solve the issue to remove the define and
accept slightly less verbose output.

As a side note, while researching this I looked at bison's cvs HEAD. It
appears bison is undergoing some fairly substantial rewriting -- bison.simple
is now in the attic.

Joe

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-09-15 14:28:39 Re: contrib/cube & contrib/seg regression fixes
Previous Message Tom Lane 2002-09-15 04:09:04 Re: Patch to return last tid