From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: contrib/dblink GRANTs and regression test fix |
Date: | 2002-09-14 21:48:48 |
Message-ID: | 3D83AEC0.6070807@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane wrote:
> Applied. The method for dropping the second database seems pretty
> cheesy itself, though; and wouldn't it make it harder to investigate
> the cause of a test failure, if one occurs? I think I'd vote for
> getting rid of the trailing wait() and DROP and instead doing
>
> \set ECHO none
> DROP DATABASE regression_slave;
> \set ECHO all
> CREATE DATABASE regression_slave;
>
I didn't give you any time for a reply, but just in case you think this
acceptable, here's a patch that does what I mentioned in the last post. Namely
it removes the wait() function and DROP DATABASE at the end of the script, and
adds a conditional_drop() function to the beginning of the script.
If there are no objections, please apply.
Thanks,
Joe
Attachment | Content-Type | Size |
---|---|---|
dblink-regress-fix.1.patch | text/plain | 3.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-09-14 21:49:23 | Re: contrib/dblink GRANTs and regression test fix |
Previous Message | Joe Conway | 2002-09-14 21:31:30 | Re: contrib/dblink GRANTs and regression test fix |