Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <jchampion(at)timescale(dot)com>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Mark Guertin <markguertin(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date: 2023-07-20 10:36:52
Message-ID: 3D7967A7-CB8A-428C-BBEA-D87AAA875055@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> On 20 Jul 2023, at 09:47, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> Hmm. Are you sure that this is correct for pg_rewind? This should
> work when using a local source with --source-pgdata, but under a
> remote source with --source-pgdata, I get the impression that we'd
> still copy a .DS_store into the target's data folder.

Ah, good point. The updated patch should work for both by moving the check
into the filemap.

--
Daniel Gustafsson

Attachment Content-Type Size
v7-0001-Skip-.DS_Store-files-in-server-side-utils.patch application/octet-stream 8.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Shashanth Reddy 2023-07-20 14:58:31 Re: BUG #18033: org.postgresql.util.PSQLException:
Previous Message Daniel Gustafsson 2023-07-20 08:47:57 Re: BUG #18033: org.postgresql.util.PSQLException: