| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | findoidjoins patch (was Re: [HACKERS] findoidjoins) |
| Date: | 2002-09-05 05:25:19 |
| Message-ID: | 3D76EABF.2070900@joeconway.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> I'd be inclined to reproduce the original behavior. findoidjoins is
> pretty slow already, and I don't much want to slow it down more in order
> to provide info that's useless for the primary purpose.
Here's take two. It produces results similar to the previous version,
but using libpq and schema aware queries.
> use it for checking the stuff in pg_catalog. So I'm not at all sure why
> I made that note. Do you get a plausible set of joins out of your
> version?
Looks reasonable to me. I attached the outputs of findoidjoins and
make_oidjoins_check for review as well.
Please review and commit, or kick back to me if more work is needed.
Thanks,
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| findoidjoins-fix.2.patch | text/plain | 16.8 KB |
| findoidjoins.out | text/plain | 3.4 KB |
| oidjoins.sql | text/plain | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-09-05 05:27:22 | Re: LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1? |
| Previous Message | Stephan Szabo | 2002-09-05 05:19:03 | Re: locking of referenced table during constraint |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dennis Björklund | 2002-09-05 05:31:22 | swedish translations for 7.3 |
| Previous Message | Tom Lane | 2002-09-04 23:04:32 | Re: fix for palloc() of user-supplied length |