Re: SRF memory mgmt patch (was [HACKERS] Concern about

From: Joe Conway <mail(at)joeconway(dot)com>
To: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: SRF memory mgmt patch (was [HACKERS] Concern about
Date: 2002-08-30 17:51:35
Message-ID: 3D6FB0A7.1080409@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Joe Conway wrote:
> I'm looking at this now. I suspect the easy fix is to remove
> ExecClearTuple from per_MultiFuncCall, but I'll try to understand what's
> going on first.
>

On second thought, *all* functions failing is what you expected, right
Tom? I just changed TupleGetDatum() as we discussed:

#define TupleGetDatum(_slot, _tuple) \
PointerGetDatum(ExecStoreTuple(_tuple, _slot, InvalidBuffer, false))

and now everything works again. Is this the preferred fix and/or is it
worth spending more time to dig into this?

Joe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthew T. OConnor 2002-08-30 17:59:22 Re: [HACKERS] pgaccess - where to store the own data
Previous Message Joe Conway 2002-08-30 17:34:32 Re: SRF memory mgmt patch (was [HACKERS] Concern about

Browse pgsql-patches by date

  From Date Subject
Next Message Joe Conway 2002-08-30 18:51:43 Re: SRF memory mgmt patch (was [HACKERS] Concern about
Previous Message Joe Conway 2002-08-30 17:34:32 Re: SRF memory mgmt patch (was [HACKERS] Concern about