| From: | Jukka Holappa <jukkaho(at)mail(dot)student(dot)oulu(dot)fi> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | [PATCH] Sprintf() patch against current CVS tree. |
| Date: | 2002-08-29 21:29:03 |
| Message-ID: | 3D6E921F.2020700@mail.student.oulu.fi |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
I checked all the previous string handling errors and most of them were
already fixed by You. However there were a few left and this patch
should fix the rest of them.
I used StringInfo only in 2 places and both of them are inside debug
ifdefs. Only performance penalty will come from using strlen() like all
the other code does.
I also modified some of the already patched parts by changing
snprintf(buf, 2 * BUFSIZE, ... style lines to
snprintf(buf, sizeof(buf), ... where buf is an array.
This patch also passes all regression testing:
======================
~ All 89 tests passed.
======================
Patch is in -c format as requested and available from
http://suihkari.baana.suomi.net/postgresql/patches/postgresql-CVS-2002-08-29-sprintf.patch
I tried to send it as attachment, but seems like nothing went through
(and my mailer would certainly mangle an inline patch).
- - Jukka
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE9bpIfYYWM2XTSwX0RAk0cAJ4odC77W2xnSAreVCrWGVTrkog02wCeN8rZ
pl0XmFUqMuGpBhSydp/rhpA=
=QVKk
-----END PGP SIGNATURE-----
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-08-29 21:45:56 | Re: fix for palloc() of user-supplied length |
| Previous Message | Jukka Holappa | 2002-08-29 21:12:22 | [PATCH] Sprintf() patch against current CVS tree. |