From: | Joe Conway <mail(at)joeconway(dot)com> |
---|---|
To: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Anonymous-record-types omission |
Date: | 2002-08-28 04:54:37 |
Message-ID: | 3D6C578D.2070304@joeconway.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Tom Lane found an omission in the committed anonymous type code. The
coldeflist in the FROM clause was not being dumped by ruleutils.c. The
attached patch fixes this. Example:
-- before --
regression=# \d pg_settings
View "pg_catalog.pg_settings"
Column | Type | Modifiers
---------+------+-----------
name | text |
setting | text |
View definition: SELECT a.name, a.setting FROM pg_show_all_settings() a;
Rules: pg_settings_u,
pg_settings_n
-- and after --
test=# \d pg_settings
View "pg_catalog.pg_settings"
Column | Type | Modifiers
---------+------+-----------
name | text |
setting | text |
View definition: SELECT a.name, a.setting FROM pg_show_all_settings()
a(name text, setting text);
Rules: pg_settings_u,
pg_settings_n
Also included is the related adjustment to expected/rules.out. If there
are no objections, please apply.
Thanks,
Joe
Attachment | Content-Type | Size |
---|---|---|
anon-type-ruleutils.fix.1.patch | text/plain | 11.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gavin Sherry | 2002-08-28 06:26:47 | Re: [HACKERS] Proposed GUC Variable |
Previous Message | Neil Conway | 2002-08-28 04:33:26 | Re: fix for palloc() of user-supplied length |