From: | Teodor Sigaev <teodor(at)stack(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: contrib/ltree for 7.2 or 7.3 ? |
Date: | 2002-07-30 18:52:11 |
Message-ID: | 3D46E05B.1000304@stack.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I'm now working on it.
Tom Lane wrote:
>>Oleg Bartunov wrote:
>>
>>>One known issue: It'll not works with 64-bit OS. We'll certainly fix this
>>>but will appreciate if somebody with access to 64-bit machine could help us.
>>
>
> Actually, it dumps core instantly on 32-bit machines too, if they are
> pickier about alignment than Intel hardware is. You can't map
> structures onto char[] arrays that start at odd byte offsets and not
> expect trouble.
>
> I also do not trust macros like this:
>
> typedef struct {
> int32 len;
> uint16 numlevel;
> char data[1];
> } ltree;
>
> #define LTREE_HDRSIZE ( sizeof(int32) + sizeof(uint16) )
>
> because they take no account of the possibility of padding between fields.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>
--
Teodor Sigaev
teodor(at)stack(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-07-30 19:44:41 | Re: START TRANSACTION |
Previous Message | Tom Lane | 2002-07-30 18:48:04 | Re: contrib/ltree for 7.2 or 7.3 ? |