Re: pgsql/ oc/src/sgml/release.sgml rc/backend/com ...

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/ oc/src/sgml/release.sgml rc/backend/com ...
Date: 2002-07-20 16:07:35
Message-ID: 3D398AC7.6070406@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Tom Lane wrote:
> CVSROOT: /cvsroot
> Module name: pgsql
> Changes by: tgl(at)postgresql(dot)org 02/07/20 11:12:56
>
> Modified files:
> doc/src/sgml : release.sgml
> src/backend/commands: explain.c
> src/backend/utils/misc: guc.c
> src/include/executor: executor.h
> src/include/utils: guc.h
> src/test/regress/expected: horology-no-DST-before-1970.out
> horology-solaris-1947.out
> horology.out
>
> Log message:
> Code review for SHOW output changes; fix horology expected files for
> new SHOW output format.

Thanks for reviewing and cleaning this up, Tom. I think I understand
most of your changes, but I wasn't sure why you changed
PointerGetDatum(PG_GETARG_TEXT_P(0))
to
PG_GETARG_DATUM(0)

Somewhere I got the impression that the former was preferred, although
the two are equivalent and the latter is more compact.

Joe

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2002-07-20 16:19:37 Re: pgsql/ oc/src/sgml/release.sgml rc/backend/com ...
Previous Message Tom Lane 2002-07-20 15:12:56 pgsql/ oc/src/sgml/release.sgml rc/backend/com ...

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-07-20 16:19:37 Re: pgsql/ oc/src/sgml/release.sgml rc/backend/com ...
Previous Message Tom Lane 2002-07-20 15:12:56 pgsql/ oc/src/sgml/release.sgml rc/backend/com ...