Re: Suggestions for implementing IS DISTINCT FROM?

From: Thomas Lockhart <lockhart(at)fourpalms(dot)org>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Suggestions for implementing IS DISTINCT FROM?
Date: 2002-06-24 04:12:04
Message-ID: 3D169C14.86C8C995@fourpalms.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I've actually already done almost all the work for converting BETWEEN to a
> node but I have a couple of questions:
> Should I use a boolean in the node to indicate whether it is SYMMETRIC or
> ASYMMETRIC, or should I use some sort of integer to indicate whether it is
> SYMMETRIC, ASYMMETRIC or DEFAULT (ASYMMETRIC). That way the reverse in
> rules and views could leave out the ASYMMETRIC if it wasn't specified
> originally, rather than always adding it in. Which is better?

Great!

I would use a boolean (or integer) to indicate two possibilities, not
three.

The language specifies what the default should be, and dump programs
could choose to omit the ASYMMETRIC if they choose. imho it is best to
resolve defaults earlier, rather than pushing the resolution deep into
the parser or even farther.

- Thomas

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tony Griffiths 2002-06-24 07:40:23 Re: ADTs and embedded sql
Previous Message Christopher Kings-Lynne 2002-06-24 03:44:56 Re: Suggestions for implementing IS DISTINCT FROM?