Re: Patches applied; initdb time!

From: Thomas Lockhart <thomas(at)fourpalms(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patches applied; initdb time!
Date: 2002-04-21 21:24:57
Message-ID: 3CC32E29.E880734D@fourpalms.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

> >> With fairly vanilla configure options, I get...
> > Please be specific on the options and platform.
> HPUX 10.20,
> ./configure --with-CXX --with-tcl --enable-cassert

Boy, how plain-vanilla. *My* configure line is all of

./configure --prefix=/home/thomas/local

But I do override some parameters in my Makefile.custom:

CFLAGS+= -g -O0 -DUSE_ASSERT_CHECKING
CFLAGS+= -DCOPY_PARSE_PLAN_TREES

Which gives me (except for the plan tree thing) something very similar.

I've looked a bit more, and the set_name_needs_quotes() is probably
obsoleted by my update, which generalizes parameter handling in SET
variables. I'll rip it out unless we get a test case in the regression
tests which demonstrates a problem. I'm pretty sure that it may have
allowed

SET key='par1 w space,par2';

but that would be handled now by

SET key='par1 w space',par2;

for cases in which "key" would accept multiple values. We now can allow
single parameters with embedded commas *and* whitespace, which would
have been impossible before. Not sure why white space is desirable
however, so the new behavior seems adequate to me.

I'm still not sure why the INT64CONST conflict does not show up as a
warning on my machine, but looking at the code I'm not sure why we would
ever have had two versions in the first place. Anyone want to take
responsibility for consolidating it into The Right Place? If not, I'll
go ahead and do it...

- Thomas

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2002-04-21 21:25:40 Re: Patches applied; initdb time!
Previous Message Tom Lane 2002-04-21 21:22:47 Re: Patches applied; initdb time!

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-04-21 21:25:40 Re: Patches applied; initdb time!
Previous Message Tom Lane 2002-04-21 21:22:47 Re: Patches applied; initdb time!