Re: Small fix for _equalValue()

From: Thomas Lockhart <lockhart(at)fourpalms(dot)org>
To: Fernando Nasser <fnasser(at)redhat(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Small fix for _equalValue()
Date: 2002-03-07 16:36:39
Message-ID: 3C879717.4C698966@fourpalms.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

...
> Someone is using NULL strings in gram.y, like in:
> n->args = makeList1(makeStringConst($4, NULL));
> there are several instances of it, all related to variable set.
> Well, NULL is a valid value for a (char *) so this seems legal
> enough to me.

Ah, that was me, to allow comma-delimited lists of parameters to be sent
to the SET handling code. In previous versions, multi-parameter
arguments had to be enclosed in quotes. For most of the SET variables,
lists aren't indicated, but I wanted to use the list for all cases to
minimize the special cases downstream.

If this should be done differently I'm happy for suggestions...

- Thomas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-03-07 16:39:02 Re: Small fix for _equalValue()
Previous Message Thomas Zehetbauer 2002-03-07 16:04:47 select max(column) not using index

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-03-07 16:39:02 Re: Small fix for _equalValue()
Previous Message Tom Lane 2002-03-07 16:00:22 Re: Small fix for _equalValue()