quotes in SET grammar

From: Thomas Lockhart <thomas(at)fourpalms(dot)org>
To: PostgreSQL Hackers List <pgsql-hackers(at)postgresql(dot)org>
Subject: quotes in SET grammar
Date: 2002-02-26 14:49:24
Message-ID: 3C7BA074.535FA222@fourpalms.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Christopher's patch to fix docs regarding single- and double-quotes in
SET syntax got me looking at gram.y. It turns out that although we allow
lists of double-quoted strings in SET, we do not allow lists of
single-quoted strings (the latter should have been preferred afaik). And
although we allow single-quoted strings in SET TIME ZONE, we do not
allow double-quoted strings! So things seem inconsistant to me.

Possible cases look like

SET TIME ZONE 'pst8pdt';
SET TIME ZONE "pst8pdt";
SET DATESTYLE = "US","ISO";

Is there any objection to allowing both single- and double-quoted
strings in SET? Or should I remove the double-quoted variety altogether?
I've got patches for the former, but am willing to consider either
solution. afaik single-quoted strings would be sufficient to cover
users' expectations, and all cases are extentions to SQL9x syntax, which
only specifies SET TIME ZONE with a numeric offset. Comments?

- Thomas

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-02-26 15:17:20 Re: Refactoring of command.c
Previous Message Art Nicewick 2002-02-26 14:09:47 Re: PostgreSQL 8.0 ??