Re: Re: WIN32 errno patch

From: Mikhail Terekhov <terekhov(at)emc(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: WIN32 errno patch
Date: 2001-08-09 22:34:23
Message-ID: 3B730FEF.B43C3BCD@emc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Tom Lane wrote:
>
> Mikhail Terekhov <terekhov(at)emc(dot)com> writes:
> > One can't just #undef errno on windows because it is defined as
> > follows:
>
> I was wondering if Windows might play any games with errno. However,
> we've had at least one instance of "errno = 0;" in the libpq sources
> since 7.0 or before, and no one has complained that it doesn't build
> on Windows ... if errno is defined as a function call, that should
> yield a compile error, no?
>

It complains but only if you build a dll or multithreaded app.

> Also, the patch is already in place, and I have a report that it works.
>

It works only when compiling static apps I think.

Regards,
Mikhail Terekhov

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Mikhail Terekhov 2001-08-09 22:42:23 Re: Re: WIN32 errno patch
Previous Message Magnus Naeslund(f) 2001-08-09 21:35:37 Re: Re: WIN32 errno patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2001-08-09 22:38:24 Vague idea for allowing per-column locale
Previous Message Magnus Naeslund(f) 2001-08-09 21:35:37 Re: Re: WIN32 errno patch

Browse pgsql-patches by date

  From Date Subject
Next Message Mikhail Terekhov 2001-08-09 22:42:23 Re: Re: WIN32 errno patch
Previous Message Magnus Naeslund(f) 2001-08-09 21:35:37 Re: Re: WIN32 errno patch