Re: pgindent run?

From: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Alfred Perlstein <bright(at)wintelcom(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, The Hermit Hacker <scrappy(at)hub(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2001-03-23 00:37:39
Message-ID: 3ABA9AD3.F4D7F765@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
>
> You don't notice the value of pgindent until you have some code that
> hasn't been run through it. For example, ODBC was not run through until
> this release, and I had a terrible time trying to understand the code
> because it didn't _look_ like the rest of the code. Now that pgindent
> is run, it looks more normal, and I am sure that will encourage more
> people to get in and make changes.
>

I see now the following comment in interfaces/odbc/statement.c.
Though it's mine(probably), it's hard for me to read.
Please tell me how to prevent pgindent from changing
comments.

/*
* Basically we don't have to begin a transaction in autocommit mode
* because Postgres backend runs in autocomit mode. We issue "BEGIN"
* in the following cases. 1) we use declare/fetch and the statement
* is SELECT (because declare/fetch must be called in a transaction).
* 2) we are in autocommit off state and the statement isn't of type
* OTHER.
*/

regards,
Hiroshi Inoue

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-03-23 00:38:47 Re: pgindent run?
Previous Message Thomas Lockhart 2001-03-23 00:14:29 Re: Problem migrating dump to latest CVS snapshot.

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-03-23 00:38:47 Re: pgindent run?
Previous Message Giles Lean 2001-03-22 20:48:08 Re: [HACKERS] Call for platforms