From: | Karl DeBisschop <kdebisschop(at)alert(dot)infoplease(dot)com> |
---|---|
To: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: RPMS for 7.1beta3 being uploaded. |
Date: | 2001-01-15 18:37:58 |
Message-ID: | 3A634386.6646CD99@alert.infoplease.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
>
> Lamar Owen writes:
>
> > Ok, I have a first set of 7.1beta3 RPMs uploading now. These RPMs pass
> > regression on my home RedHat 6.2 machine, which has all locale environment
> > variables disabled (/etc/sysconfig/i18n deleted and a reboot).
>
> Some thoughts:
snip
> | -#!/usr/local/bin/perl -w
> | +#!/usr/bin/perl -w
> (and more of these for Python)
>
> I think this should be fixed to read
>
> #! /usr/bin/env perl
>
> Any comments?
What assurance do you have that 'env' is in /usr/bin? Linux FHS
(http://www.pathname.com/fhs/2.1/fhs-4.2.html) says that when perl
is in some location other than /usr/bin, then symlinks should be
provided to /usr/bin/perl. You don't have this assurance with
/usr/bin/env. Maybe there are some unices that do not have perl in
/usr/bin - but maybe there are unices that put 'env' into /bin
instead of /usr/bin. If you follow the current FHS, /usr/bin/perl
may be better -- but I'm not sure if that is entirely true of the
real world of linux boxes out there.
> | # copy over the includes needed for SPI development.
> | pushd src/include
> | /lib/cpp -M -I. -I../backend executor/spi.h | \
> | xargs -n 1| \
> | grep \\W| \
> | grep -v ^/| \
> | grep -v spi.o | \
> | grep -v spi.h | \
> | sort | \
> | cpio -pdu $RPM_BUILD_ROOT/usr/include/pgsql
>
> I think the standard installed set of headers is sufficient.
I haven't installed the RPM yet. But I dissent unless things have
changed from 7.0 in that respect. I copmile against executor/spi.h,
based on the examples in the docs. Should I be using something else?
(I'll have to go look at the 7.1 source, but I just wanted to
register at least some comfusion, if not dissent)
--
Karl DeBisschop
kdebisschop(at)alert(dot)infoplease(dot)com
Learning Network Reference http://www.infoplease.com
Netsaint Plugin Developer
kdebisschop(at)users(dot)sourceforge(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Karl DeBisschop | 2001-01-15 18:54:24 | Re: RPMS for 7.1beta3 being uploaded. |
Previous Message | Peter Eisentraut | 2001-01-15 17:50:39 | Re: RPMS for 7.1beta3 being uploaded. |