Re: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea

Hmm, I've seen neither my posting nor your reply
on hackers ML.

Tom Lane wrote:
>
> "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
> >> Why? What difference do you see in the nature of the critical sections?
> >> They all look the same to me: hold off cancel/die response.
>
> > I've thought that the main purpose of CRIT_SECTION is to
> > force redo recovery for any errors during the CRIT_SECTION
> > to complete the critical operation e.g. bt_split().
>
> How could it force redo?

Doesn't proc_exit(non-zero) force shuttdown recovery ?
AFAIK, Postgres doesn't have a rollback recovery
functionality yet.

> Rollback, maybe, but that should happen
> anyway.
>
> > Note that elog(ERROR/FATAL) is changed to elog(STOP) if Critical
> > SectionCount > 0.
>
> Not in current sources ;-).
>

Oh you removed the code 20 hours ago. AFAIK, the (equivalent)
code has lived there from the first appearance of CRIT_SECTION.
Is there any reason to remove the code ?

Regards.
Hiroshi Inoue