| From: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | inoue(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql/src/backend/utils/adt (ri_triggers.c) |
| Date: | 2000-11-21 09:54:24 |
| Message-ID: | 3A1A4650.DFE9B07B@tpf.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> inoue(at)postgresql(dot)org writes:
> > Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/adt
> > Modified Files:
> > ri_triggers.c
> > keep relations open until they are no longer needed.
>
> Something that's been bothering me for a good while about ri_triggers
> is that it opens the relations without any lock to begin with.
> That can't possibly be safe, can it?
Opening relations with no lock seems illegal to me.
Though I have no evidence that it does wrong thing
in ri_triggers.c,it seems that we had better acquire
an AccessShareLock on trial.
I sometimes see SEGV error around ri stuff and
I've doubted opening relations with no lock.
However the cause was different from it.
Hiroshi Inoue
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vadim Mikheev | 2000-11-21 10:01:55 | Re: [HACKERS] Re: pgsql/src/backend/access/transam (xlog.c) |
| Previous Message | vadim | 2000-11-21 09:39:58 | pgsql/src/backend/bootstrap (bootstrap.c) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vadim Mikheev | 2000-11-21 10:01:55 | Re: [HACKERS] Re: pgsql/src/backend/access/transam (xlog.c) |
| Previous Message | Philip Warner | 2000-11-21 08:10:56 | RE: Table/Column Constraints |