From: | Christof Petig <christof(dot)petig(at)wtal(dot)de> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jacek Jakubowski <ma0027(at)uni-wuppertal(dot)de>, Michael Meskes <meskes(at)postgresql(dot)org> |
Subject: | Re: Leaking definitions to user programs |
Date: | 2000-11-03 14:53:33 |
Message-ID: | 3A02D16D.77061340@wtal.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Bruce, Hi Michael,
here is the really short patch for shutting out all postgres definitions
from ecpg
programs. (e.g. Datum, Pointer, DEBUG, ERROR).
Someone really should take a look into libpq and do the same.
But I had to copy a small part of c.h (bool,true,false,TRUE,FALSE) into
ecpg/include/libecpg.h. And ... there is a possible bug in c.h. You
can't check a
typedef via #ifndef.
typedef char bool;
...
#ifndef bool
typedef char bool;
#endif
will fail. But I don't know any decent solution to that problem!
Perhaps c.h should be broken into seperate parts.
Christof
PS: to Jacek: you need this patch to compile libcommon++.a!
Bruce Momjian wrote:
> Thanks.
>
> > > Yes, leaking into user programs is a bad practice. Is there a
> > > solution/patch for that?
> >
> > A solution would be a simple patch which is not available yet. But I plan on
> > doing one (some other things still have higher priority).
> >
> > Christof
Attachment | Content-Type | Size |
---|---|---|
ecpg.diff.gz | application/x-gzip | 405 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Ned Lilly | 2000-11-03 15:07:39 | live chat on associative model databases (starts 11:00 ET today) |
Previous Message | Zeugswetter Andreas SB | 2000-11-03 14:05:27 | AW: relation ### modified while in use |