Re: CVS broken?

Philip Warner wrote:

> I get the following when I build from CVS:
>
> gcc -I../../../src/include -I../../../src/interfaces/libpq -O2 -g -Wall
> -Wmissing-prototypes -Wmissing-declarations -o pg_dump pg_dump.o common.o
> pg_backup_archiver.o pg_backup_db.o pg_backup_custom.o pg_backup_files.o
> pg_backup_null.o pg_backup_tar.o -L../../..
> /src/interfaces/libpq -lpq -lz -lcrypt -lnsl -ldl -lm -lreadline -lncurses
> -lz
> ../../../src/interfaces/libpq/libpq.so: undefined reference to
> `FailedAssertion'
> ../../../src/interfaces/libpq/libpq.so: undefined reference to
> `assert_enabled'
> ../../../src/interfaces/libpq/libpq.so: undefined reference to
> `ExceptionalCondition'
>
> Does anyone else have this problem?
>

I have already encountered the problem.
-DFRONTEND isn't set in the above command line.

For example the following line
CFLAGS+= -DFRONTEND -I$(srcdir)
in makefiles doesn't work currently.

I found the recent change in Makefile.global.in.
ifeq ($(GCC), yes)
override CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
endif

Do we have to override CFLAGS every time ?

Regards.

Hiroshi Inoue