Re: Bloom index cost model seems to be wrong

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Thomas Kellerer <spam_eater(at)gmx(dot)net>, pgsql-performance(at)lists(dot)postgresql(dot)org
Subject: Re: Bloom index cost model seems to be wrong
Date: 2019-02-12 21:17:23
Message-ID: 3997.1550006243@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-performance

Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> In order for bloom (or any other users of CREATE ACCESS METHOD, if there
> are any) to have a fighting chance to do better, I think many of selfuncs.c
> currently private functions would have to be declared in some header file,
> perhaps utils/selfuncs.h. But that then requires a cascade of other
> inclusions. Perhaps that is why it was not done.

I'm just in the midst of refactoring that stuff, so if you have
suggestions, let's hear 'em.

It's possible that a good cost model for bloom is so far outside
genericcostestimate's ideas that trying to use it is not a good
idea anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-02-12 22:00:22 Re: Too rigorous assert in reorderbuffer.c
Previous Message Jeff Janes 2019-02-12 19:56:40 Re: Bloom index cost model seems to be wrong

Browse pgsql-performance by date

  From Date Subject
Next Message Jeff Janes 2019-02-12 22:38:28 Re: Bloom index cost model seems to be wrong
Previous Message Jeff Janes 2019-02-12 19:56:40 Re: Bloom index cost model seems to be wrong