Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16

Hi,

On 2/16/23 1:26 PM, Drouvot, Bertrand wrote:
> Hi,
>
> On 2/16/23 12:00 PM, Amit Kapila wrote:
>> I think this would require XLOG_PAGE_MAGIC as it changes the WAL record.
>>
>
> Oh, I Was not aware about it, thanks! Will do in V2 (and in the logical
> decoding on standby patch as it adds the new field mentioned above).
>
>> BTW, how about a commit message like:
>> Change xl_hash_vacuum_one_page.ntuples from int to uint16.
>>
>> This will create two bytes of padding space in xl_hash_vacuum_one_page
>> which can be used for future patches. This makes the datatype of
>> xl_hash_vacuum_one_page.ntuples same as gistxlogDelete.ntodelete which
>> is advisable as both are used for the same purpose.
>>
>
> LGTM, will add it to V2!
>
Please find V2 attached.
The commit message also mention the XLOG_PAGE_MAGIC bump.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com