| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Is this a problem in GenericXLogFinish()? |
| Date: | 2023-09-26 19:32:13 |
| Message-ID: | 399492009193fa2c37a61b630e4449546a550039.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2023-09-25 at 13:04 +0300, Heikki Linnakangas wrote:
> Yes, that's a problem.
Patch attached. I rearranged the code a bit to follow the expected
pattern of: write, mark dirty, WAL, set LSN. I think computing the
deltas could also be moved earlier, outside of the critical section,
but I'm not sure that would be useful.
Do you have a suggestion for any kind of test addition, or should we
just review carefully?
> I wish we had an assertion for that. XLogInsert() could assert that
> the
> page is already marked dirty, for example.
Unfortunately that's not always the case, e.g. log_newpage_range().
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-GenericXLogFinish.patch | text/x-patch | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2023-09-26 20:19:12 | Re: Add const qualifiers |
| Previous Message | Jim Jones | 2023-09-26 18:40:52 | Re: [PATCH] Add inline comments to the pg_hba_file_rules view |