| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Subject: | Re: Parallel query hangs after a smart shutdown is issued |
| Date: | 2020-08-13 04:58:02 |
| Message-ID: | 398962.1597294682@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> Makes sense. I tested this version on a primary and a replica and
> verified that parallel workers launch, but I saw that autovacuum
> workers still can't start without something like this:
> @@ -2463,7 +2463,8 @@ canAcceptConnections(int backend_type)
> * be returned until we have checked for too many children.
> */
> if (smartShutState != SMART_NORMAL_USAGE &&
> - backend_type != BACKEND_TYPE_BGWORKER)
> + backend_type != BACKEND_TYPE_BGWORKER &&
> + backend_type != BACKEND_TYPE_AUTOVAC)
Hmmm ... maybe that should be more like
if (smartShutState != SMART_NORMAL_USAGE &&
backend_type == BACKEND_TYPE_NORMAL)
(the adjacent comment needs adjustment too of course).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-08-13 05:11:08 | Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE |
| Previous Message | Thomas Munro | 2020-08-13 04:42:49 | Re: Parallel query hangs after a smart shutdown is issued |