Re: Importing pg_bsd_indent into our source tree

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Importing pg_bsd_indent into our source tree
Date: 2023-02-09 23:19:06
Message-ID: 3972584.1675984746@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
>> Hmmm .. a shell script would be fine by me, but it won't help in
>> testing a Windows build. Maybe we need to make it a Perl script?

> At least for casual testing a shell script actually mostly works, due to git
> it's easy enough to have a sh.exe around... Not something I'd necessarily want
> to make a hard dependency, but for something like this it might suffice. Of
> course perl would be more dependable...

Yeah, also less question about whether it works on Windows.
I'll see about moving that into Perl. It's short enough.

>> BTW, the attachments to your previous message are identical to what
>> I previously posted --- did you attach the wrong set of diffs?

> I attached an extra patch, in addition to yours.

D'oh, I didn't notice that :-(

> I also attached yours so that
> cfbot could continue to work, if you registered this.

I thought about registering it, but that won't teach us anything unless
we make it built-by-default, which was not my intention. I guess we
could temporarily include it in the build.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeroen Vermeulen 2023-02-09 23:25:45 libpq: PQgetCopyData() and allocation overhead
Previous Message Tom Lane 2023-02-09 23:12:50 Re: Generating code for query jumbling through gen_node_support.pl