Re: change regexp_substr first argument make tests more easier to understand.

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: change regexp_substr first argument make tests more easier to understand.
Date: 2024-08-13 09:40:00
Message-ID: 396935e9-f111-49a1-a5c7-eb91e5fcc714@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi everybody

Current tests with regexp_instr() and regexp_substr()  with string
'abcabcabc' are really unreadable and you would spend time to understand
that happens in these tests and if they are really correct. I'd better
change them into "abcdefghi" just like in query

    SELECT regexp_substr('abcdefghi', 'd.q') IS NULL AS t;

Regards

Ilia Evdokimov,
Tantor Labs LLC.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hao Zhang 2024-08-13 09:45:21 Why not align item size in dshash_table?
Previous Message Bertrand Drouvot 2024-08-13 08:11:11 Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state