Re: BUG #17826: An assert failed in /src/backend/optimizer/util/var.c

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Mon, 13 Mar 2023 at 10:43, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Ah, got it. So basically, the quals that we want are excluded by
>> check_output_expressions' point 4 (since they reference window
>> function output columns rather than partitioning columns). I think
>> we need them to satisfy every other property that's checked in this
>> code, though. Now I agree that we need to refactor a bit -- we
>> don't want to have to re-check all of these conditions.

> OK, patch attached.

This looks good to me. As a matter of style, I'd capitalize the
enum constant names, but I think it's OK otherwise.

> I probably need to do a bit more indenting work. I'll look again tomorrow.

Yeah, this looks like pgindent might not like it as-is.

regards, tom lane