Re: Shorter iterations of join_info_list

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Shorter iterations of join_info_list
Date: 2013-07-24 04:10:28
Message-ID: 3952.1374639028@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

[ sorry for slow response, this month has been mostly crazy ]

Antonin Houska <antonin(dot)houska(at)gmail(dot)com> writes:
> As far as I understand, deconstruct_recurse() ensures that
> SpecialJoinInfo of a new join always gets added to higher position in
> join_info_list than SJ infos of all joins located below the new join in
> the tree. I wonder if we can rely on that fact sometimes.

FWIW, I think of most of those planner lists as being unordered sets.
Depending on a particular ordering definitely adds fragility; so I'd
not want to introduce such a dependency without solid evidence of a
substantial speed improvement. The cases you mention don't seem very
likely to offer any noticeable gain at all --- at least, I don't recall
seeing any of those functions show up high in profiles.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2013-07-24 04:16:28 Re: Proposal/design feedback needed: WITHIN GROUP (sql standard ordered set aggregate functions)
Previous Message Noah Misch 2013-07-24 03:08:51 Re: Suggestion for concurrent index creation using a single full scan operation