Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Date: 2022-03-31 01:01:07
Message-ID: 393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On Mar 30, 2022, at 8:19 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Make PostgreSQL::Test::Cluster compatible with all live branches
>
> prairiedog is unhappy [1], seemingly as a result of this patch:
>
> t/001_repl_stats....Can't locate parent.pm in @INC (@INC contains: ../../src/test/perl/ . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl . /usr/local/perl5.8.3/lib/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/5.8.3 /usr/local/perl5.8.3/lib/site_perl/5.8.3/darwin-2level /usr/local/perl5.8.3/lib/site_perl/5.8.3 /usr/local/perl5.8.3/lib/site_perl .) at ../../src/test/perl//PostgreSQL/Test/Cluster.pm line 2921.
> BEGIN failed--compilation aborted at ../../src/test/perl//PostgreSQL/Test/Cluster.pm line 2921.
>
> I think this means that its old Perl version misinterprets
>
> use parent -norequire, qw(PostgreSQL::Test::Cluster);
>
> as a request to include "parent.pm". Is there a more
> backwards-compatible way to spell that?

Not that I know of. Googling tells me it was a core module from 5.10.1. I can revert tomorrow if necessary :-(

Cheers

Andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-03-31 01:12:20 Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches
Previous Message Tom Lane 2022-03-31 00:19:41 Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches