Re: recovery_target_time and last completed transaction log time

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: recovery_target_time and last completed transaction log time
Date: 2008-10-30 03:39:31
Message-ID: 3921.1225337971@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> writes:
> Regarding the LOG message, it is confusing to have a recovery.conf
> file which contains this:
> recovery_target_time = '2008-10-16 17:00:00.0'
> and see this in the log:
> [2008-10-16 23:04:26.006 CDT] 19951 LOG: last completed transaction
> was at log time 2008-10-16 17:00:23.205347-05

Actually, I think this *is* a bug: recoveryLastXTime is being set in
entirely the wrong place, ie, where we are *considering* whether to
apply a commit rather than after we have decided to do so. The
result is just a misleading log message, so not too terrible, but
we should fix it.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2008-10-30 04:49:10 Re: pre-MED
Previous Message Josh Berkus 2008-10-30 03:28:07 Re: Please make sure your patches are on the wiki page