| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Date: | 2024-09-04 09:28:24 |
| Message-ID: | 390f9699-6275-4e1e-a600-11452bee0576@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.09.24 22:56, Jacob Champion wrote:
>> The parse_strval field could use a better explanation.
>>
>> I actually don't understand the need for this field. AFAICT, this is
>> just used to record whether strval is valid.
> No, it's meant to track the value of the need_escapes argument to the
> constructor. I've renamed it and moved the assignment to hopefully
> make that a little more obvious. WDYT?
Yes, this is clearer.
This patch (v28-0001) looks good to me now.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2024-09-04 09:29:48 | Re: scalability bottlenecks with (many) partitions (and more) |
| Previous Message | shveta malik | 2024-09-04 09:18:51 | Re: Introduce XID age and inactive timeout based replication slot invalidation |