Re: run pgindent on a regular basis / scripted manner

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Jelte Fennema <postgres(at)jeltef(dot)nl>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: 2023-02-10 15:21:49
Message-ID: 390e7b04-11f3-f715-7a7d-d1a9077fbea8@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-02-10 Fr 04:25, Jelte Fennema wrote:
> Ah yes, I had seen that when I read the initial --commit patch but
> then forgot about it when the flag didn't work at all when I tried it.
>
> Attached is a patch that fixes the issue. And also implements the
> --dirty and --staged flags in pgindent that Robert Haas requested.

[please don't top-post]

I don't think just adding a diff filter is really a sufficient fix. The
file might have been deleted since the commit(s) in question. Here's a
more general fix for missing files.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Attachment Content-Type Size
pgindent-missing-file-fix.patch text/x-patch 1018 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-02-10 15:33:55 Re: Can we do something to help stop users mistakenly using force_parallel_mode?
Previous Message Tom Lane 2023-02-10 15:18:34 Re: pg_usleep for multisecond delays